Remove duplicate error message on chart connection failure #8476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
approved these changes
Apr 20, 2020
ashb
commented
Apr 20, 2020
| @@ -160,9 +160,6 @@ <h4 class="panel-title"> | |||
| url = "{{ url_for('airflow.chart_data') }}" + location.search; | |||
| $.getJSON(url, function(payload) { | |||
| $('#loading').hide(); | |||
| if (payload.error !== undefined) { | |||
| $('#chart_body').html('<div class="alert alert-danger">' + payload.error + '</div>'); | |||
There was a problem hiding this comment.
The error is still shown by the error function on L181
potiuk
approved these changes
Apr 20, 2020
This caused the error message to be shown twice - once in the chart body (which is faded out) and again at the "top-level" error
ashb
force-pushed
the
no-duplicate-error-on-chart
branch
from
91b6c46
to
f8a3f91
Compare
Codecov Report
@@ Coverage Diff @@
## v1-10-test #8476 +/- ##
==============================================
- Coverage 81.86% 81.30% -0.56%
==============================================
Files 542 542
Lines 37221 37223 +2
==============================================
- Hits 30471 30265 -206
- Misses 6750 6958 +208
Continue to review full report at Codecov.
|
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
May 4, 2020
This caused the error message to be shown twice - once in the chart body (which is faded out) and again at the "top-level" error (cherry picked from commit ecf0494)
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Jun 15, 2020
This caused the error message to be shown twice - once in the chart body (which is faded out) and again at the "top-level" error (cherry picked from commit ecf0494) (cherry picked from commit b779c59c1303faa14ac32204fa7afc169441531b)
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Jun 15, 2020
This caused the error message to be shown twice - once in the chart body (which is faded out) and again at the "top-level" error (cherry picked from commit ecf0494) (cherry picked from commit b779c59c1303faa14ac32204fa7afc169441531b)
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
This caused the error message to be shown twice - once in the chart body (which is faded out) and again at the "top-level" error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused the error message to be shown twice - once in the chart body
(which is faded out) and again at the "top-level" error
[AIRFLOW-XXXX]for document-only changesIn case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.